fix(core)!: Use ValueError for missing 'items' in array parameters #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview This PR improves the developer experience by providing more specific and actionable errors. When a tool parameter of type `array` was defined without its required `items` key, the SDK would raise a generic `Exception`. This made it difficult to distinguish this specific validation failure from other unexpected runtime exceptions. This change corrects the behavior by raising a `ValueError`, which is the semantically appropriate exception for this scenario. The error message has also been slightly updated for consistency. ### Before * Error Type: `Exception` * Error Message: `"Unexpected value: type is 'list' but items is None"` ### After * Error Type: `ValueError` * Error Message: `"Unexpected value: type is 'array' but items is None"` ## Testing The unit test `test_parameter_schema_array_no_items_error` has been updated to reflect these changes.
kurtisvg
approved these changes
Aug 2, 2025
|
/gcbrun |
dishaprakash
approved these changes
Aug 4, 2025
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the developer experience by providing more specific and actionable errors. When a tool parameter of type
arraywas defined without its requireditemskey, the SDK would raise a genericException. This made it difficult to distinguish this specific validation failure from other unexpected runtime exceptions.This change corrects the behavior by raising a
ValueError, which is the semantically appropriate exception for this scenario. The error message has also been slightly updated for consistency.Before
Exception"Unexpected value: type is 'list' but items is None"After
ValueError"Unexpected value: type is 'array' but items is None"Testing
The unit test
test_parameter_schema_array_no_items_errorhas been updated to reflect these changes.